Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(meson): fix issues with meson builds #137

Merged
merged 6 commits into from
Aug 8, 2023

Conversation

jdhughes-usgs
Copy link
Collaborator

  • add test that tests meson builds for all targets
  • add test that tests makefile build except for targets with c++ and libmf6

* add test that tests meson builds for all targets
* add test that tests makefile build except for targets with c++ and libmf6
@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

Merging #137 (5dd0f6c) into master (3bf53a2) will increase coverage by 8.153%.
The diff coverage is 83.333%.

@@              Coverage Diff              @@
##            master      #137       +/-   ##
=============================================
+ Coverage   73.397%   81.550%   +8.153%     
=============================================
  Files           20        20               
  Lines         3432      3469       +37     
=============================================
+ Hits          2519      2829      +310     
+ Misses         913       640      -273     
Files Changed Coverage Δ
pymake/cmds/build.py 0.000% <0.000%> (ø)
pymake/cmds/mfpymakecli.py 0.000% <ø> (ø)
pymake/pymake_base.py 91.153% <ø> (+4.871%) ⬆️
pymake/pymake_parser.py 27.272% <ø> (ø)
pymake/utils/_compiler_switches.py 76.109% <76.470%> (-0.091%) ⬇️
pymake/utils/_meson_build.py 91.984% <88.235%> (+64.484%) ⬆️
pymake/pymake_build_apps.py 86.725% <100.000%> (+6.194%) ⬆️

... and 6 files with indirect coverage changes

* remove `working_directory()` from conftest.py
* black and isort
* add mf6dev, zbud6dev, and libmf6dev
* remove default double precision builds for mfusg, mf2005, mflgr, and mfnwt
@jdhughes-usgs jdhughes-usgs merged commit 5cd534b into modflowpy:master Aug 8, 2023
14 of 15 checks passed
@jdhughes-usgs jdhughes-usgs deleted the meson-fix branch August 8, 2023 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant